Yicong-Huang opened a new pull request, #5191:
URL: https://github.com/apache/texera/pull/5191

   ### What changes were proposed in this PR?
   
   Closes #5190. Extends the existing `code-debugger.component.spec.ts` and 
`code-editor.component.spec.ts` with tests for the class-level surface that the 
original specs left behind. No Monaco-editor interaction is added — the parts 
that require a real editor are left for a future browser-mode pass.
   
   A latent test-setup bug surfaced while writing the new debugger tests: the 
spec built `debugState` from `new Y.Map<…>()` directly, which silently never 
fires observers because the map is not attached to a Y.Doc. Production never 
hits this — `UdfDebugService` hands out maps from a real doc — but every Y.Map 
observer test would have stayed at 0 coverage until the map was wired into a 
doc. Switching to `new Y.Doc().getMap(…)` fixes it.
   
   ### Any related issues, documentation, discussions?
   
   Closes #5190.
   
   ### How was this PR tested?
   
   `yarn ng test --watch=false --include=…` runs 2 spec files / 39 tests, all 
green. `yarn lint` and `yarn format:ci` both clean. v8 line coverage:
   
   - `code-debugger.component.ts`: 38% → 76% (+38pp)
   - `code-editor.component.ts`: 38% → 49% (+11pp)
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 4.7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to