Yicong-Huang opened a new pull request, #5194:
URL: https://github.com/apache/texera/pull/5194
### What changes were proposed in this PR?
Closes #5193. `sync-texera-model.spec.ts` was carrying ~344 lines of dead
test code: four `it()` blocks commented out against a `SyncTexeraModel`
constructor that took an `OperatorGroup` third argument. `OperatorGroup` was
removed from the codebase long ago, the constructor is now two-arg, and
`SyncTexeraModel` no longer handles operator-delete events at all — so each
commented test depended on a class that doesn't exist and exercised behavior
that's been moved elsewhere. One nearby live test claimed to assert the
operator-delete error path but never instantiated the SUT and made no
assertions; it was vacuous.
Drop the four commented blocks, their preceding doc blocks, the vacuous live
test, and the now-orphaned `getJointOperatorValue` helper. Add a
`describe("getOperatorLink", …)` that hits the static helper's two `throw`
branches directly — the stream-handler tests can't reach them because
`isValidJointLink` filters those cases out upstream.
### Any related issues, documentation, discussions?
Closes #5193.
### How was this PR tested?
`yarn ng test --watch=false --include=…` runs 9 tests, all green. `yarn
lint` and `yarn format:ci` both clean. v8 line coverage of
`sync-texera-model.ts` rises from 94 % (31/33) to 100 % (33/33); the spec
itself shrinks 747 → 449 lines.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
