Yicong-Huang opened a new pull request, #5196:
URL: https://github.com/apache/texera/pull/5196
### What changes were proposed in this PR?
Closes #5195. `joint-ui.service.spec.ts` opened with ~60 commented test
lines plus an `it.todo("add unit tests for JointUIService")` placeholder. Five
of the seven methods those commented tests called were removed from
`JointUIService` long ago (`getJointOperatorStatusTooltipElement`,
`changeOperatorStates`, `changeOperatorTooltipInfo`, `showToolTip`,
`hideTooltip`); the commented block is unrevivable dead code.
Delete that block and the now-redundant placeholder. Add direct coverage for
the public surface the spec was leaving behind — static helpers
(`getOperatorFillColor`, `getOperatorCacheDisplayText`, `getOperatorCacheIcon`,
`getOperatorViewResultIcon`, `getJointLinkCell`, `getJointUserPointerName`,
`getJointUserPointerCell`), joint-paper-bound methods (`changeOperatorColor`,
`changeOperatorState`, `foldOperatorDetails`/`unfoldOperatorDetails`,
`showAgentActionLabel`/`hideAgentActionLabel`, `getCommentElement`), and
`getJointOperatorElement`'s unknown-operator-type throw branch.
### Any related issues, documentation, discussions?
Closes #5195. Same shape as #5194.
### How was this PR tested?
`yarn ng test --watch=false --include=…` runs 42 tests, all green. `yarn
lint` and `yarn format:ci` both clean. v8 line coverage of
`joint-ui.service.ts` rises from 34 % (75/220) to 70 % (155/220).
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
