Yicong-Huang opened a new pull request, #5213:
URL: https://github.com/apache/texera/pull/5213

   ### What changes were proposed in this PR?
   
   Adds `ExecutionsMetadataPersistServiceSpec`, a `MockTexeraDB`-backed unit 
spec covering the three methods on `ExecutionsMetadataPersistService` plus the 
`ExecutionStateStore.updateWorkflowState` wrapper that sits on top of 
`tryUpdateExistingExecution`. The MockTexeraDB trait (already used by 
`WorkflowExecutionsResourceSpec` and peers) spins up an EmbeddedPostgres in 
`beforeAll`, loads `sql/texera_ddl.sql`, and tears down in `afterAll`.
   
   Two latent silent-failure patterns are pinned with explanatory comments and 
filed as follow-up bugs: `tryGetExistingExecution` returns `Some(null)` instead 
of `None` for unknown eids, and `insertNewExecution` propagates a NOT NULL 
violation when `uid=None` despite the `Option[Integer]` signature. The pinned 
`Some(null)` test is paired with an `intercept[TestFailedException]`-based 
xfail-strict test asserting the intended `None` contract — it flips red the day 
the bug is fixed.
   
   ### Any related issues, documentation, discussions?
   
   Closes #5210. Surfaces #5211 and #5212.
   
   ### How was this PR tested?
   
   Added unit tests under `amber/src/test/scala/org/apache/texera/web/service/`.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Opus 4.7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to