xuang7 opened a new pull request, #5215:
URL: https://github.com/apache/texera/pull/5215
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to
Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
This PR adds a card view to the dataset listing, with a toggle to switch
between the existing list view and the new card view for public dataset.
Applied to the public dataset listing (/dashboard/hub/dataset/result).
Changes:
- Added DatasetCardItemComponent (frontend/.../user/dataset-card-item/,
renders a dataset card with cover image, title, owner avatar + name,
last-updated time, size, view count, and a like button. View mode persists
per-user via localStorage.
- Decoupled SearchResultsComponent from any specific card component. It
now accepts a cardTemplate: TemplateRef input, allowing each consumer to
provide its own card via <ng-template> projection. The
card branch is gated on viewMode === 'card' && cardTemplate.
- Extracted formatCount ("1.5k" style) and formatRelativeTime ("5 minutes
ago" style) into frontend/src/app/common/util/format.util.ts. These mirror
logic that already exists inline in the components (list-item, dataset-detail,
hub-workflow-detail, user-computing-unit-list-item); the new card consumes the
shared util.
- Added HubService.toggleLike helper, encapsulating the like/unlike +
refresh-count flow.
- Projected DATASET.COVER_IMAGE through UnifiedResourceSchema and
DatasetSearchQueryBuilder so search responses include the cover path needed by
the card.
<img width="1561" height="775" alt="public-dataset"
src="https://github.com/user-attachments/assets/23b84f3f-a39e-4ffa-98a5-67f39d48a626";
/>
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves
#1234`
or `Closes #1234`. If it is only related, simply mention the issue
number.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Discussion #5130
Related to #4216 (workflow card view; same framework can later be applied).
Follow-up TODOs:
- [ ] 1. Enable card view on the user's personal dataset listing
(/dashboard/user/dataset).
- [ ] 2. Fix cover image loading for private datasets (<img> requests can't
carry the JWT header).
- [ ] 3. Replace the inline copies of formatCount and formatRelativeTime
with the shared utility functions.
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if the
PR
is tested with existing test cases. Make sure to include/update test cases
that
check the changes thoroughly including negative and positive cases if
possible.
If it was tested in a way different from regular unit tests, please clarify
how
you tested step by step, ideally copy and paste-able, so that other
reviewers can
test and check, and descendants can verify in the future. If tests were not
added,
please describe why they were not added and/or why it was difficult to add.
-->
Added test cases and manually tested.
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Claude Opus 4.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
