Yicong-Huang opened a new pull request, #5219:
URL: https://github.com/apache/texera/pull/5219
### What changes were proposed in this PR?
Add six ScalaTest specs covering a self-contained cluster of pure-logic
helpers under `amber/src/main/scala/org/apache/texera/web/resource/` that ship
without direct unit coverage.
- `EmailTemplateSpec` — admin / user branches of
`userRegistrationNotification`, optional-field fallbacks, role-change template
per `UserRoleEnum`.
- `FulltextSearchQueryUtilsSpec` — pgroonga and fallback `to_tsvector`
predicates, `getContainsFilter` OR + set dedup, `getDateFilter` open-ended
endpoints + end-of-day bump + `ParseException`, `getOperatorsFilter`
case-insensitive LIKE.
- `EntityTablesSpec` and `EntityTypeSpec` — hub dispatch tables for
`Workflow` and `Dataset`, `CloneTable`'s asymmetric IAE on `Dataset`, Jackson
`@JsonValue` / `@JsonCreator` round-trip.
- `HealthCheckResourceSpec` and `SuccessExecutionResultSpec` — the trivial
contracts that deployment manifests and the frontend success-handler rely on.
Pins one quirky edge case in
`FulltextSearchQueryUtils.getFullTextSearchFilter`:
`keywords.filter(_.nonEmpty)` is applied before `map(_.trim)`, so a
whitespace-only keyword survives and produces a degenerate
`pgroonga_condition('', ...)` predicate. A future fix (move the trim into the
filter step) would break that pinned test deliberately.
### Any related issues, documentation, discussions?
Closes #5217.
### How was this PR tested?
Added unit tests under
`amber/src/test/scala/org/apache/texera/web/resource/`.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
