Ma77Ball opened a new pull request, #5221:
URL: https://github.com/apache/texera/pull/5221
### What changes were proposed in this PR?
- Change `tryGetExistingExecution` in `ExecutionsMetadataPersistService`
to wrap the DAO call with `Option(...)` instead of `Some(...)`, so a missing
row (jOOQ returns `null`) collapses to `None` rather than `Some(null)`.
- Keep the existing `catch Throwable` block, which still earns its keep
for hard DB errors (e.g. closed connection); the `Option` wrap only addresses
the no-row miss path.
- Update `ExecutionsMetadataPersistServiceSpec` (added in #5213): replace
the two paired pin tests (the `Some(null)` pin and the inverted
`intercept[TestFailedException]` xfail-strict) with a single positive `shouldBe
None` test.
### Any related issues, documentation, or discussions?
Closes: #5211. Depends on #5213 (test scaffolding); rebase after it lands.
### How was this PR tested?
- Ran `sbt scalafmtAll` (no rewrites needed).
- `ExecutionsMetadataPersistServiceSpec.tryGetExistingExecution` now has
positive tests for both the hit (`Some(row)`) and the miss (`None`) cases.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
