Ma77Ball opened a new pull request, #5234:
URL: https://github.com/apache/texera/pull/5234

   ### What changes were proposed in this PR?
   - Add `landing-page.component.spec.ts` covering creation, the constructor's 
`userChanged()` subscription (login/logout transitions update `isLogin` and 
`currentUid`), `ngOnInit` calling both `getWorkflowCount` and `loadTops`, count 
population from `HubService.getCount`, the three top-loved buckets populated by 
`loadTops`, the `loadTops` error path logging via `console.error`, 
`getTopLovedEntries` enriching items via 
`SearchService.extendSearchResultsWithHubActivityInfo(items, true, ["access"])` 
per action and returning a map keyed by action, and `navigateToSearch` routing 
for `"workflow"`, `"dataset"`, and unknown types.
   - Stub `HubService`, `SearchService`, `WorkflowPersistService`, and 
`DatasetService`; reuse `StubUserService` for a real `userChanged()` subject; 
replace `Router.navigate` with a vitest spy.
   ### Any related issues, documentation, or discussions?
   Closes: #5225
   ### How was this PR tested?
   - Ran `yarn ng test --watch=false 
--include='src/app/hub/component/landing-page/landing-page.component.spec.ts'`, 
10/10 tests pass.
   - Ran `yarn format:fix` (1 file formatted, 505 unchanged).
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.7 in compliance with ASF


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to