zyratlo commented on code in PR #5055:
URL: https://github.com/apache/texera/pull/5055#discussion_r3305637613
##########
sql/texera_ddl.sql:
##########
@@ -435,6 +437,28 @@ CREATE TABLE IF NOT EXISTS computing_unit_user_access
FOREIGN KEY (uid) REFERENCES "user"(uid) ON DELETE CASCADE
);
+-- notebook table
+CREATE TABLE IF NOT EXISTS notebook
+(
+ nid SERIAL NOT NULL PRIMARY KEY,
+ wid INT NOT NULL,
+ notebook JSONB NOT NULL,
+ FOREIGN KEY (wid) REFERENCES workflow(wid) ON DELETE CASCADE
+);
Review Comment:
I agree that indexing `wid` would help here. Since this is tied to the
discussion on whether to make `wid` UNIQUE, I will wait for our decision on
that before making changes. If we decide to make `wid` UNIQUE, then no further
work needs to be done here. If we keep `wid` non-UNIQUE, I will add the CREATE
INDEX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
