Ma77Ball opened a new pull request, #5241:
URL: https://github.com/apache/texera/pull/5241

   ### What changes were proposed in this PR?
   - Adds a browser-mode companion spec, code-editor.component.browser.spec.ts, 
that covers the four paths the jsdom spec cannot reach: the 
initializeMonacoEditor subscribe body (readOnly toggle, MonacoBinding wiring, 
AI-action registration), initializeDiffEditor's diff config path, the OpenAI 
gate in setupAIAssistantActions, the type-annotation action's 
getScrolledVisiblePosition branch, and the onWindowResize -> editor.layout() 
handler. y-monaco's MonacoBinding is mocked via vi.hoisted so the constructor 
records its args without needing a real Y.Text + monaco TextModel.
   - Adds src/browser-buffer-polyfill.ts and wires it as the first setupFile in 
vitest.browser.config.ts so monaco-editor-wrapper and 
monaco-vscode-files-service-override can be imported under package by listing 
it in optimizeDeps.include so Vite's import-scan picks it up despite the 
setup-file indirection.
   - Broadens the gui:test-browser target's include glob to 
**/*.browser.spec.ts in angular.json, and adds the same pattern to gui:test's 
exclude list so the two runners do not double-execute.
   ### Any related issues, documentation, or discussions?
   Closes: #5192
   ### How was this PR tested?
   - yarn nx run gui:test-browser: 29/29 passing (7 new code-editor + 22 
existing workflow-editor).
   - yarn nx run gui:test: 623 passed, 2 skipped, 1 todo (no regression from 
the exclude change).
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.7 in compliance with ASF
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to