Ma77Ball opened a new pull request, #5246:
URL: https://github.com/apache/texera/pull/5246

   ### What changes were proposed in this PR?
   - Wrap the body of `test_write_after_upload_error_raises_error` in 
`try/finally` and call `stream.close()` inside the `with patch.object(...)` 
scope so the failed-upload stream cannot survive as a zombie past the test 
boundary.
   - No production code change. `large_binary_output_stream.py` is unchanged.
   ### Any related issues, documentation, or discussions?
   Closes: #5245
   ### How was this PR tested?
   - Reproduced the CI failure deterministically on Python 3.12.13 by running 
the leaky test followed by `test_delete_object_failure_is_swallowed` with a 
forced `gc.collect()` between them, confirming the duplicate `delete_object` 
call.
   - Re-ran the same scenario after the fix: both tests pass, no duplicate 
`delete_object` call.
   - Ran the full `test_large_binary_output_stream.py` file on Python 3.12.13 
and 3.13.11 (26 tests pass on each).
   - `ruff check` and `ruff format --check` clean over `src/main/python` and 
`src/test/python`.
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.7 in compliance with ASF


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to