aglinxinyuan commented on PR #5160: URL: https://github.com/apache/texera/pull/5160#issuecomment-4581872271
This fix doesn't seem to be correct. A significant amount of region-related code was removed in #4495, so I'd expect more changes to be needed here. Please manually test the feature and verify that it works as expected before requesting another review. It's quite inefficient for reviewers to be responsible for testing the feature and then reporting issues back to the author. Otherwise, the review process can easily turn into several rounds of back-and-forth before the fix is actually validated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
