Ma77Ball opened a new pull request, #5300:
URL: https://github.com/apache/texera/pull/5300

   ### What changes were proposed in this PR?
   - Changed `ExecutionsMetadataPersistService.insertNewExecution` to take a 
required `uid: Integer` instead of `Option[Integer]`, and added `require(uid != 
null, ...)` so a missing uid fails fast with a clear message instead of a 
cryptic jOOQ NOT NULL `DataAccessException`.
   - Updated the only production caller 
(`WorkflowService.initExecutionService`) to pass `uidOpt.orNull`, keeping the 
single validation point inside the service method.
   - Updated `ExecutionsMetadataPersistServiceSpec`: the case that previously 
pinned the jOOQ violation now asserts the `IllegalArgumentException` fail-fast 
contract, and the happy-path calls pass a bare `Integer`.
   ### Any related issues, documentation, or discussions?
   Closes: #5212
   ### How was this PR tested?
   - Compiled amber main + test sources under JDK 17 (clean).
   - Ran `WorkflowExecutionService/testOnly 
...ExecutionsMetadataPersistServiceSpec`: all 9 tests pass.
   - Ran `sbt scalafmtAll` (no changes) and `scalafmtCheck` for main and test 
scopes (clean).
   ### Was this PR authored or co-authored using generative AI tooling?
   Co-authored with Claude Opus 4.7 in compliance with ASF
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to