bobbai00 commented on code in PR #5303:
URL: https://github.com/apache/texera/pull/5303#discussion_r3331089586


##########
.github/workflows/create-release-candidate.yml:
##########
@@ -174,14 +174,14 @@ jobs:
 
           # Export the single-node directory from the tagged source
           mkdir -p "$TEMP_DIR/_raw"
-          git archive --format=tar "$TAG_NAME" -- bin/single-node/ sql/ | tar 
-x -C "$TEMP_DIR/_raw"
+          git archive --format=tar "$TAG_NAME" -- bin/single-node/ sql/ NOTICE 
| tar -x -C "$TEMP_DIR/_raw"
 
           # Copy deployment files
           cp "$TEMP_DIR/_raw/bin/single-node/docker-compose.yml" "$BUNDLE_DIR/"
           cp "$TEMP_DIR/_raw/bin/single-node/nginx.conf" "$BUNDLE_DIR/"
           cp "$TEMP_DIR/_raw/bin/single-node/litellm-config.yaml" 
"$BUNDLE_DIR/"
           cp "$TEMP_DIR/_raw/bin/single-node/LICENSE" "$BUNDLE_DIR/"

Review Comment:
   the LICENSE in the project root: 
https://github.com/apache/texera/blob/main/LICENSE contains additional 
attribution on 3rd-party code, which doesn't apply to this docker compose 
bundle. So I suggest we don't clean up LICENSE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to