PG1204 opened a new issue, #5318: URL: https://github.com/apache/texera/issues/5318
### Task Summary ### Context PR #5146 (which fixes #3614) commented out six mouse-event tests in [workflow-editor.component.spec.ts](https://github.com/apache/texera/blob/main/frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts) so the spec file could be removed from the angular.json exclusion list and run under the default jsdom test target. The six tests fail under jsdom because they depend on JointJS event paths (HTMLCanvasElement.getContext, SVG hit-testing, jQuery .trigger("mousedown"/"dblclick") dispatch) that jsdom doesn't implement, but they pass under ng run gui:test-browser (real Chrome via Playwright). Each commented-out block is marked with a TODO(#3614) header in the spec file. ### Tests to restore - should try to highlight the operator when user mouse clicks on an operator - should highlight the commentBox when user clicks on a commentBox - should open commentBox as NzModal when user double clicks on a commentBox - should unhighlight all highlighted operators when user mouse clicks on the blank space - should highlight multiple operators when user clicks on them with shift key pressed - should unhighlight the highlighted operator when user clicks on it with shift key pressed ### Proposed approach Move the six tests into a new sibling file workflow-editor.browser.spec.ts (uncommented), with its own TestBed setup. The .browser.spec.ts convention introduced after #5146 means jsdom skips this file and the test-browser target runs it, so no angular.json changes are needed. Remove the commented-out blocks and any orphan imports they leave behind in workflow-editor.component.spec.ts. ### Alternative considered Polyfilling the jsdom gaps (canvas, SVG hit-testing, JointJS event dispatch) to keep everything in one file. Likely much more invasive and a moving target as JointJS evolves; not preferred unless a maintainer has a strong reason to keep the file split avoided. ### Related PR #5146 Issue #3614 ### Task Type - [x] Refactor / Cleanup - [ ] DevOps / Deployment / CI - [ ] Testing / QA - [ ] Documentation - [ ] Performance - [ ] Other -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
