Ma77Ball commented on PR #5435: URL: https://github.com/apache/texera/pull/5435#issuecomment-4641135652
Thanks for this! One thing though: `hoconParser` isn't used anywhere anymore. The call was removed in #3150 and the import in #3415, so this `.d.ts` stub and the `hocon-parser` dependency (plus `hoconjs` on line 10) are now just dead code. So changing the return type polishes something nothing uses. The more useful change would be to **remove** the unused stub and deps instead, and that'd be a nice cleanup you'd get credit for. If you want to take it on: 1. Open an issue first using our issue template. 2. Follow our PR template (e.g. title `chore(pyright-language-service): remove unused hocon-parser dependency`). If not, no worries, I'm happy to pick it up. Either way I think we should close this PR. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
