bobbai00 commented on code in PR #5417:
URL: https://github.com/apache/texera/pull/5417#discussion_r3369009489
##########
.github/workflows/build.yml:
##########
@@ -246,6 +246,21 @@ jobs:
/tmp/dists/amber-*/lib || check_exit=$?
./bin/licensing/audit_jar_licenses.py /tmp/dists/amber-*/lib || true
exit "$check_exit"
+ - name: Verify amber NOTICE-binary matches generator output
+ # amber/NOTICE-binary is generated from the bundled jars'
META-INF/NOTICE
+ # content via bin/licensing/generate_notice_binary.py, plus
+ # amber/NOTICE-binary-python for the python-only (non-jar)
attributions.
+ # Regenerate against the amber dist lib dir unzipped by the step above
+ # and diff against the committed file. Drift means a dep was added,
+ # removed, or bumped without rerunning the generator — fix by running:
+ # ./bin/licensing/generate_notice_binary.py amber/NOTICE-binary
/tmp/dists/amber-*/lib --extras amber/NOTICE-binary-python
Review Comment:
merged
##########
.github/workflows/build.yml:
##########
@@ -603,6 +618,20 @@ jobs:
/tmp/dists/${{ matrix.service }}-*/lib || check_exit=$?
./bin/licensing/audit_jar_licenses.py /tmp/dists/${{ matrix.service
}}-*/lib || true
exit "$check_exit"
+ - name: Verify ${{ matrix.service }} NOTICE-binary matches generator
output
+ # Each service's NOTICE-binary is generated from its bundled jars'
+ # META-INF/NOTICE content via bin/licensing/generate_notice_binary.py.
+ # Regenerate against the dist lib dir unzipped by the step above and
+ # diff against the committed file. Drift means a dep was added,
removed,
+ # or bumped without rerunning the generator — fix by running:
+ # ./bin/licensing/generate_notice_binary.py ${{ matrix.service
}}/NOTICE-binary /tmp/dists/${{ matrix.service }}-*/lib
+ run: |
+ set -euo pipefail
+ ./bin/licensing/generate_notice_binary.py /tmp/notice-${{
matrix.service }}.txt /tmp/dists/${{ matrix.service }}-*/lib
Review Comment:
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
