kunwp1 opened a new pull request, #5602:
URL: https://github.com/apache/texera/pull/5602
Backport of #5280 to `release/v1.2`.
As noted in #5569, this cannot be a single cherry-pick: #5280's changes to
`large_binary_output_stream.py` build on top of #5249 ("keep failed-upload
cleanup inside the upload worker"), which is not present on `release/v1.2`.
Cherry-picking #5280 alone leaves a dangling reference to the
`large_binary_manager` module in `_cleanup_failed_upload()` (which #5249
removes), producing a `NameError` at runtime.
This PR therefore backports the dependency chain:
1. **#5249** — keep failed-upload cleanup inside the upload worker
(prerequisite)
2. **#5280** — scope large binary storage and cleanup by execution id
Both are clean `git cherry-pick -x` of the original squash commits. #4707
(which #5249 follows up on) is already present on `release/v1.2`, so the chain
stops there.
### Verification
- After applying the chain, every file touched by #5280 is
**byte-identical** to its state on `main` at the merged #5280 commit
(`48e800e4`).
- `release/v1.2` had no independent changes to any of these files.
- No remaining callers of the removed `deleteAllObjects()`;
`deleteByExecution` is wired in `WorkflowResource` and `WorkflowService`.
### Related
- Backports #5280 (closes #4123 on `main`)
- Prerequisite: #5249
- Unblocks the #5569 backport, which can then cherry-pick cleanly onto
`release/v1.2`.
### Was this PR authored or co-authored using generative AI tooling?
Backport prepared with Claude Code (Claude Opus 4.8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
