SarahAsad23 commented on code in PR #5577: URL: https://github.com/apache/texera/pull/5577#discussion_r3399358724
########## frontend/src/app/dashboard/component/user/user-venv/user-venv.component.html: ########## @@ -0,0 +1,183 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +<div class="section-container subsection-grid-container"> + <nz-card class="section-title"> + <h2 class="page-title">Environments</h2> + <div class="button-group"> + <button + nz-button + class="create-btn" + (click)="showPveModal()" + title="Create Environment"> + <i + nz-icon + nzType="file-add" + nzTheme="outline"></i> + <span>Create Environment</span> + </button> + </div> + </nz-card> + + <nz-card + class="section-list-container" + [nzBodyStyle]="{ height: '100%' }"> + <div class="python-env-page"> + <div + *ngIf="pves.length === 0" + class="python-env-page-empty"> + No environments yet. Click <strong>Create Python Venv</strong> to create one. + </div> + + <ul + *ngIf="pves.length > 0" + class="python-env-page-list"> + <li + *ngFor="let pve of pves; let i = index; trackBy: trackByVeid" + class="python-env-page-item" + (click)="openExistingPve(i)"> + <span class="python-env-name">{{ pve.name || "(unnamed)" }}</span> + <i + nz-icon + nzType="delete" + class="python-env-delete-icon" + nz-tooltip + nzTooltipTitle="Delete environment" + (click)="confirmDeletePve(i); $event.stopPropagation()" + role="button" + aria-label="Delete Python environment"> + </i> + </li> + </ul> + </div> + </nz-card> +</div> + +<nz-modal + nzWrapClassName="pve-modal" + nzClassName="pve-modal" + [nzVisible]="pveModalVisible" + nzTitle="Python Environments" Review Comment: The modal itself is specific to Python virtual environments, so I think the UI should clearly indicate that the environment being created is a Python virtual environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
