aglinxinyuan commented on code in PR #4206:
URL: https://github.com/apache/texera/pull/4206#discussion_r3406866771
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/workflow/PhysicalOp.scala:
##########
@@ -198,6 +198,7 @@ case class PhysicalOp(
// schema propagation function
propagateSchema: SchemaPropagationFunc = SchemaPropagationFunc(schemas =>
schemas),
isOneToManyOp: Boolean = false,
+ isLoopEnd: Boolean = false,
Review Comment:
You're right — the rename was lost in a rebase. Re-applied in 3d4f15b445.
`isLoopEnd` → `reusesOutputStorageOnReExecution` (named after the behavior
the scheduler checks — "keep this operator's output storage across a region
re-run" — not after LoopEnd):
* `PhysicalOp`: field + `withIsLoopEnd` →
`withReusesOutputStorageOnReExecution`, with a doc comment stating the behavior
and that any operator needing it can set it.
* `RegionExecutionCoordinator`: the skip-recreate guard now checks
`region.getOperators.exists(_.reusesOutputStorageOnReExecution)` (local val +
comment reworded to the behavior).
* `LoopEndOpDesc` sets `.withReusesOutputStorageOnReExecution(true)`.
* Loop specs + mixin updated.
So the next operator that must preserve its output across a region
re-execution can reuse the flag without a LoopEnd-specific misnomer.
Verified: WorkflowCore + WorkflowOperator compile and all 29
LoopStart/LoopEnd op-desc specs pass. (Heads up: the `amber` module's local
compile is currently blocked by an unrelated pre-existing issue — `PveManager`
from #5577 references the `virtual_environments` table, which my un-migrated
local DB lacks, so JOOQ codegen omits it; that's environmental and CI compiles
against a fresh schema. The `RegionExecutionCoordinator` edit is a one-token
rename to the now-existing field.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
