Ma77Ball opened a new issue, #5669:
URL: https://github.com/apache/texera/issues/5669

   ## Task Summary
   
   Follow-up from PR #5545 ([review 
comment](https://github.com/apache/texera/pull/5545#discussion_r3393706149)).
   
   `GuiConfigService.loadPostLogin()` fetches `/config/gui`, `/config/amber`, 
and `/config/user-system` and spreads them all into a single flat `this.config` 
map. This loses the information about which source each key came from.
   
   Yicong's review:
   > this design is horrible. it merges configs from different sources into one 
map, essentially loses the isolated information. I think in a future PR we 
should at least make them reserve the source of the config. e.g.,
   > `this.config['amber'] = amberConfig`
   
   ### Scope
   - Restructure `GuiConfigService` so config from each endpoint stays 
namespaced by its source (e.g. `config.amber`, `config.gui`, 
`config.userSystem`) rather than flattened together.
   - Update consumers that read these config values accordingly.
   - Update `gui-config.service.spec.ts`.
   
   ### Task Type
   Refactor / Cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to