Ma77Ball opened a new issue, #5668:
URL: https://github.com/apache/texera/issues/5668

   ## Task Summary
   
   Follow-up from PR #5545 ([review 
comment](https://github.com/apache/texera/pull/5545#discussion_r3369720909)).
   
   `ApplicationConfig` physically lives in the `common/config` module, but its 
package is `org.apache.texera.amber.config`. Because of the package name, call 
sites such as `config-service`'s `ConfigResource` import 
`org.apache.texera.amber.config.ApplicationConfig`, which *reads* as a 
dependency on the `amber` module even though there is none.
   
   Yicong's review:
   > config service should not depend on amber. we need to separate them.
   > we should rename the package then.... to be done in separate PR.
   
   ### Scope
   - Rename the `org.apache.texera.amber.config` package (in `common/config`) 
to a name that reflects its real home (e.g. `org.apache.texera.config` 
alongside the other config objects, or another agreed-upon name).
   - Update all import sites across the codebase (amber, config-service, etc.).
   - No behavioral change; pure rename/refactor.
   
   ### Task Type
   Refactor / Cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to