juliethecao commented on PR #5651: URL: https://github.com/apache/texera/pull/5651#issuecomment-4697191167
| Case | Current behavior | Why | |---|---|---| | Adding a new file | `git blame` fails (caught), skips file → "No candidates found" | File didn't exist at base commit — nothing to blame | | Modifying a file | `git blame` succeeds → suggests committers/non-committers | This is the primary intended use case | | Deleting a file | Skipped entirely (`status === 'removed'`) → "No candidates found" | File existed at base so blame is technically possible, but see note below | For all three test PRs, I used `.github/welcome-first-time-contributor.txt` as the test file to add it, modify it, and delete it respectively. - Add case: https://github.com/juliethecao/texera/pull/10 - Modify case: https://github.com/juliethecao/texera/pull/11 - Delete case: https://github.com/juliethecao/texera/pull/12 Let me know if the modify case should use a more representative file (e.g. something with richer blame history across more contributors). On the delete case: I currently skip deleted files, but since the file existed at the base commit, `git blame` would technically work. That said, I'm not sure it's the right call as whoever is deleting a file likely already knows what they're doing and is the most appropriate reviewer themselves. Happy to change the logic if you think surfacing blame candidates for deletions would be useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
