Copilot commented on code in PR #5698: URL: https://github.com/apache/texera/pull/5698#discussion_r3408763194
########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/source/sql/mysql/MySQLConnUtilSpec.scala: ########## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.source.sql.mysql + +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.BeforeAndAfterAll + +import java.lang.reflect.{InvocationHandler, Method, Proxy} +import java.sql.{Connection, Driver, DriverManager, DriverPropertyInfo, SQLException} +import java.util.Properties +import java.util.logging.Logger +import scala.collection.mutable.ArrayBuffer +import scala.jdk.CollectionConverters._ + +class MySQLConnUtilSpec extends AnyFlatSpec with BeforeAndAfterAll { + + // --------------------------------------------------------------------------- + // Strategy — same capturing-driver pattern as PostgreSQLConnUtilSpec. + // The MySQL driver may or may not be present transitively, so we + // proactively deregister anything that claims jdbc:mysql: and swap in a + // capturing driver that records each URL and returns a Proxy-backed + // Connection so the production code can call `setReadOnly(true)`. + // --------------------------------------------------------------------------- Review Comment: PR description says `MySQLConnUtilSpec` relies on DriverManager's default "No suitable driver" exception path and lists 8 tests. The added spec actually uses the capturing-driver approach (like the PG spec) and contains more than 8 test cases. Please update the PR description / checklist so it matches the implemented strategy and test count to avoid confusing reviewers and future maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
