kunwp1 commented on code in PR #5644:
URL: https://github.com/apache/texera/pull/5644#discussion_r3424193037
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:
##########
@@ -800,6 +804,7 @@ export class ComputingUnitSelectionComponent implements
OnInit {
isLocked: true,
}));
+ this.systemPackagesLoading = true;
Review Comment:
I think it's cleaner to set this flag at the top of `getPVEs()`. If so, you
should also reset it in the outer `fetchPVEs()` error handler.
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:
##########
@@ -139,6 +139,10 @@ export class ComputingUnitSelectionComponent implements
OnInit {
// variables for creating a virtual environment
pves: PveDraft[] = [];
systemPackages: { name: string; version: string }[] = [];
+ // True while the first /pve/system response is in flight. The server
resolves
Review Comment:
This comment is not correct because the flag is set on every `getPVEs()` not
just the first. Please change the wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
