Copilot commented on code in PR #5791:
URL: https://github.com/apache/texera/pull/5791#discussion_r3440711569
##########
amber/src/test/python/core/architecture/managers/test_statistics_manager.py:
##########
@@ -101,13 +101,20 @@ def test_zero_processing_time_is_allowed(self):
assert stats.control_processing_time == 0
@pytest.mark.parametrize(
- "method",
- ["increase_data_processing_time", "increase_control_processing_time"],
+ "method, attr",
+ [
+ ("increase_data_processing_time", "_data_processing_time"),
+ ("increase_control_processing_time", "_control_processing_time"),
+ ],
)
Review Comment:
This test reaches into private accumulator fields (e.g.,
`_data_processing_time`). Since `StatisticsManager` already exposes these via
`get_statistics()`, asserting through the public API makes the test more
resilient to internal refactors. Also, the comment says “silently” but the
implementation logs a warning; consider rewording to “without raising”.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
