Copilot commented on code in PR #5827: URL: https://github.com/apache/texera/pull/5827#discussion_r3447535292
########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/visualization/htmlviz/HtmlVizOpDescSpec.scala: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.visualization.htmlviz + +import org.apache.texera.amber.core.executor.OpExecWithClassName +import org.apache.texera.amber.core.tuple.{Attribute, AttributeType, Schema} +import org.apache.texera.amber.core.virtualidentity.{ExecutionIdentity, WorkflowIdentity} +import org.apache.texera.amber.operator.metadata.OperatorGroupConstants +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +class HtmlVizOpDescSpec extends AnyFlatSpec with Matchers { + + private val workflowId = WorkflowIdentity(1L) + private val executionId = ExecutionIdentity(1L) + + "HtmlVizOpDesc.operatorInfo" should "advertise the name and Media visualization group" in { + val info = (new HtmlVizOpDesc).operatorInfo + info.userFriendlyName shouldBe "HTML Visualizer" + info.operatorGroupName shouldBe OperatorGroupConstants.VISUALIZATION_MEDIA_GROUP + info.inputPorts should have length 1 + info.outputPorts should have length 1 + } + + "HtmlVizOpDesc.htmlContentAttrName" should "default to the empty string" in { + (new HtmlVizOpDesc).htmlContentAttrName shouldBe "" + } Review Comment: PR description/issue scope says HtmlVizOpDescSpec pins `htmlContentAttrName` annotations (and that all configs round-trip through the polymorphic base), but this spec currently only checks the default value. Consider either adding reflection-based annotation assertions (like UrlVizOpDescSpec does for @JsonProperty/@AutofillAttributeName/@NotNull) and a small JSON round-trip test for HtmlVizOpDesc, or updating the PR description to match what’s actually covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
