aglinxinyuan opened a new pull request, #5833: URL: https://github.com/apache/texera/pull/5833
### What changes were proposed in this PR? Pin behavior of three core non-source operator descriptors in `common/workflow-operator/`. No production-code changes. | Spec | Source class | Tests | | --- | --- | --- | | `IfOpDescSpec` | `IfOpDesc` | 4 | | `DummyOpDescSpec` | `DummyOpDesc` | 5 | | `AggregateOpDescSpec` | `AggregateOpDesc` | 4 | **Behavior pinned — `IfOpDesc`** | Surface | Contract | | --- | --- | | `operatorInfo` | `If`, CONTROL_GROUP; 2 inputs (`Condition` at `PortIdentity()`, data at `PortIdentity(1)`); 2 outputs `False`/`True` | | `conditionName` | defaults to `null` | | `getPhysicalOp` | wires `IfOpExec`, non-parallelizable, port identities carried | | Schema propagation | routes the **data** input's schema (`inputPorts.last`) to **both** outputs; the condition-port schema is dropped | **Behavior pinned — `DummyOpDesc`** | Surface | Contract | | --- | --- | | `operatorInfo` | `Dummy`, UTILITY_GROUP; all four `dynamicInputPorts`/`dynamicOutputPorts`/`supportReconfiguration`/`allowPortCustomization` flags `true` | | Port derivation | null port lists → single default `InputPort()`/`OutputPort()`; explicit `PortDescriptor` list → one port per element, indexed by position | | `dummyOperator` | defaults to `""` | | `getPhysicalOp` | the unimplemented `LogicalOp` stub → `NotImplementedError` | **Behavior pinned — `AggregateOpDesc`** | Surface | Contract | | --- | --- | | `operatorInfo` | `Aggregate`, AGGREGATE_GROUP, 1-in/1-out, `supportReconfiguration == false` | | `getPhysicalPlan` | a two-stage (`localAgg` + `globalAgg`) plan with one connecting link | | Schema propagation | group-by keys + per-aggregation result column; SUM keeps the input type, COUNT → INTEGER, AVERAGE → DOUBLE | **Note for reviewers:** each `AggregateOpDesc` test builds a **fresh** descriptor — `getPhysicalPlan` mutates `aggregations` via `getFinal` (e.g. COUNT → SUM) and is intentionally not idempotent. ### Any related issues, documentation, discussions? Closes #5830. ### How was this PR tested? - `sbt "WorkflowOperator/testOnly org.apache.texera.amber.operator.ifStatement.IfOpDescSpec org.apache.texera.amber.operator.dummy.DummyOpDescSpec org.apache.texera.amber.operator.aggregate.AggregateOpDescSpec"` — 13 tests, all green - `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt "WorkflowOperator/Test/scalafix --check"` — clean - CI to confirm ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8 [1M context]) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
