Copilot commented on code in PR #5845: URL: https://github.com/apache/texera/pull/5845#discussion_r3447914690
########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/metadata/OperatorGroupConstantsSpec.scala: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.metadata + +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +class OperatorGroupConstantsSpec extends AnyFlatSpec with Matchers { + + import OperatorGroupConstants._ + + "OperatorGroupConstants" should "pin the canonical group-name string values" in { + INPUT_GROUP shouldBe "Data Input" + SEARCH_GROUP shouldBe "Search" + CLEANING_GROUP shouldBe "Data Cleaning" + JOIN_GROUP shouldBe "Join" + SET_GROUP shouldBe "Set" + AGGREGATE_GROUP shouldBe "Aggregate" + SORT_GROUP shouldBe "Sort" + UTILITY_GROUP shouldBe "Utilities" + VISUALIZATION_GROUP shouldBe "Visualization" + VISUALIZATION_BASIC_GROUP shouldBe "Basic" + VISUALIZATION_SCIENTIFIC_GROUP shouldBe "Scientific" + VISUALIZATION_FINANCIAL_GROUP shouldBe "Financial" + CONTROL_GROUP shouldBe "Control Block" + } Review Comment: The test says it pins the canonical OperatorGroupConstants group-name string values, but it only asserts a subset (it omits DATABASE_GROUP, API/UDF groups, ML groups, and several visualization subgroup constants). This leaves parts of OperatorGroupConstants unpinned and makes the test name misleading. Consider either (a) asserting all group-name constants defined in OperatorGroupConstants, or (b) renaming the test to indicate it's only covering a subset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
