Yicong-Huang commented on code in PR #5783:
URL: https://github.com/apache/texera/pull/5783#discussion_r3448888873
##########
amber/src/main/python/core/architecture/managers/console_message_manager.py:
##########
@@ -30,3 +37,32 @@ def get_messages(self, force_flush: bool = False) ->
Iterator[ConsoleMessage]:
def put_message(self, msg: ConsoleMessage) -> None:
self.print_buf.put(msg)
+
+ def report_exception(self, worker_id: str, exc_info: ExceptionInfo) ->
None:
Review Comment:
can we move this out? the manager is responsive for the message management,
without worry about what's inside the message. that's why the interfaces are
all on the `msg: ConsoleMessage` level.
You can have a separate util place to create a message, for this case, an
Error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
