Yicong-Huang commented on code in PR #5743:
URL: https://github.com/apache/texera/pull/5743#discussion_r3449175176
##########
config-service/src/main/scala/org/apache/texera/service/ConfigService.scala:
##########
@@ -72,6 +74,8 @@ class ConfigService extends
Application[ConfigServiceConfiguration] with LazyLog
environment.jersey.register(new ConfigResource)
+ ConfigService.enforceRoleAnnotations(environment)
Review Comment:
Two comments:
1. is it possible to move this method to common/auth so that any service can
invoke it? currently I think this is defined once for each service?
2. This is runtime check. Are there any solution to push to compilation time
check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
