Yicong-Huang commented on code in PR #5781:
URL: https://github.com/apache/texera/pull/5781#discussion_r3463988231
##########
amber/src/main/scala/org/apache/texera/web/service/WorkflowService.scala:
##########
@@ -292,11 +292,23 @@ class WorkflowService(
executionService.onNext(execution)
execution.executeWorkflow()
} catch {
- case e: Throwable => errorHandler(e)
+ case e: Throwable =>
+ errorHandler(e)
+ reportFatalErrorsToSubscribers(executionStateStore)
Review Comment:
ok my understanding (based on your explanation and code) is that you have
two error reporting phases:
1. during executionService creation phase, you report directly without going
through state store.
2. after executionService got created (and published) successfully, we route
to use state store to detect diff and report error
I think that's a fair design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
