Copilot commented on code in PR #5923: URL: https://github.com/apache/texera/pull/5923#discussion_r3464471108
########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/source/sql/asterixdb/AsterixDBSourceOpDescSpec.scala: ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.source.sql.asterixdb + +import org.apache.texera.amber.core.executor.OpExecWithClassName +import org.apache.texera.amber.core.workflow.WorkflowContext.{ + DEFAULT_EXECUTION_ID, + DEFAULT_WORKFLOW_ID +} +import org.apache.texera.amber.operator.LogicalOp +import org.apache.texera.amber.operator.metadata.OperatorGroupConstants +import org.apache.texera.amber.util.JSONUtils.objectMapper +import org.scalatest.flatspec.AnyFlatSpec +import org.scalatest.matchers.should.Matchers + +class AsterixDBSourceOpDescSpec extends AnyFlatSpec with Matchers { + + "AsterixDBSourceOpDesc.operatorInfo" should + "advertise the AsterixDB source in the Database Connector group with no input and one output" in { + val info = (new AsterixDBSourceOpDesc).operatorInfo + info.userFriendlyName shouldBe "AsterixDB Source" + info.operatorDescription shouldBe "Read data from a AsterixDB instance" + info.operatorGroupName shouldBe OperatorGroupConstants.DATABASE_GROUP Review Comment: The expected operatorDescription string uses grammatically incorrect wording ("a AsterixDB"). Since this test pins the exact description, it will also lock in that typo and make a future fix look like a breaking change. Consider correcting the user-facing description in AsterixDBSourceOpDesc and updating this assertion accordingly ("an AsterixDB instance"). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
