kunwp1 commented on code in PR #5901: URL: https://github.com/apache/texera/pull/5901#discussion_r3478604785
########## frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts: ########## Review Comment: In the previous PR, your `user-venv.component.ts` checks the virtual environment name as non-empty only but here the name that are not alphanumeric strings are rejected. The check logic needs to be consistent. Otherwise, I can imagine the case where the user saves an env with `_` in the dashboard and install the env to the CU and gets an error. ########## frontend/src/app/workspace/component/power-button/computing-unit-selection.component.spec.ts: ########## Review Comment: Please add the test that covers `parseDbPackages` and `refreshAvailableDbPves`. Also, please add more tests with the venv names to validate `installFromSavedPve`) ########## frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts: ########## Review Comment: Reset `availableDbPves` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
