Yicong-Huang opened a new issue, #5972:
URL: https://github.com/apache/texera/issues/5972

   ### Task Summary
   
   Follow-up to #5970 / #5971 (Tier 1: deleted `deploy-daemon.sh`, 
`deploy-docker.sh`, `build.sh`, `frontend-dev.sh`). With those gone, the 
per-service `*.sh` wrappers they called into are orphans — every one is a 
one-liner `target/<svc>-*/bin/<svc>` invocation that the dist launcher (or 
`bin/local-dev.sh`) already covers.
   
   Delete:
   
   | Script | What it does | Why dead |
   |---|---|---|
   | `bin/server.sh` | `(cd amber && 
target/texera-*/bin/texera-web-application)` | **Already broken** — dist is 
`amber-*` now, not `texera-*`. Only callers were `deploy-daemon.sh` + 
`deploy-docker.sh`. |
   | `bin/config-service.sh` | `target/config-service-*/bin/config-service` | 
One-liner; only caller was `deploy-daemon.sh`. |
   | `bin/file-service.sh` | `target/file-service-*/bin/file-service` | Same 
shape, same story. |
   | `bin/computing-unit-managing-service.sh` | 
`target/computing-unit-managing-service-*/bin/computing-unit-managing-service` 
| Same. |
   | `bin/workflow-compiling-service.sh` | 
`target/workflow-compiling-service-*/bin/workflow-compiling-service` | Same. |
   | `bin/workflow-computing-unit.sh` | 
`target/texera-*/bin/computing-unit-master` | **Already broken** (same 
`texera-*` issue); only callers were the deleted deploy scripts. |
   | `bin/shared-editing-server.sh` | `(cd frontend && npx y-websocket)` | 
Already covered by `yarn start`'s `concurrently --kill-others "npx y-websocket" 
"ng serve"`; only caller was `deploy-daemon.sh`. |
   | `bin/frontend.sh` | `(cd frontend && yarn install && yarn run build)` | 
Production build wrapper; only caller was the deleted `build.sh`. |
   | `bin/python-language-service.sh` | pyright / pylsp launcher | Never 
referenced — pylsp ships via `bin/pylsp/Dockerfile`'s `ENTRYPOINT 
["…","run_pylsp.sh"]`. |
   | `bin/build-services.sh` | `sbt clean dist` + unzip each service's zip | 
**Already broken** — `unzip amber/target/universal/texera-*.zip` won't match 
(now `amber-*`). Only callers were `deploy-daemon.sh` + `build.sh` (both 
deleted) and one prose mention in `bin/README.md`. |
   
   Also remove the orphan README mention of `build-services.sh`. Keep 
`bin/build-images.sh` and `bin/pylsp/run_pylsp.sh` — both have active callers 
(README and `bin/pylsp/Dockerfile` respectively).
   
   Lands after #5971 to keep the chain consistent (this PR's diff is meaningful 
only on top of those Tier 1 deletions).
   
   ### Task Type
   
   - [x] Refactor / Cleanup
   - [x] DevOps / Deployment / CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to