mengw15 opened a new pull request, #6045: URL: https://github.com/apache/texera/pull/6045
### What changes were proposed in this PR? Three Iceberg specs — `IcebergDocumentSpec`, `IcebergDocumentConsoleMessagesSpec`, and `IcebergTableStatsSpec` — resolve a **live** Iceberg catalog in their per-test setup (`beforeEach`/`beforeAll` create documents through `DocumentFactory` / `IcebergCatalogInstance.getInstance()`), so none of their cases can run without a catalog. Today the amber unit job runs them against the postgres catalog it provisions; once that job stops provisioning one they would fail. This PR moves them from `common/workflow-core/src/test/scala/...` to `amber/src/test/integration/...` — where the `@IntegrationTest` filter (`AMBER_TEST_FILTER`) already applies and `IcebergRestCatalogIntegrationSpec` already lives — and tags the three concrete specs `@IntegrationTest`. The shared `VirtualDocumentSpec` base (extended only by the first two) moves with them. Packages are unchanged, so this is a pure file move plus one import and one annotation per spec. Tagging in place is not sufficient: `common/workflow-core/build.sbt` does not read `AMBER_TEST_FILTER`, so `@IntegrationTest` would be ignored there. **`IcebergUtilSpec` intentionally stays in `common/workflow-core`.** Unlike the three above it `extends AnyFlatSpec` with no catalog setup and never calls `getInstance()`; its cases are pure Texera↔Iceberg type/schema/tuple conversions plus one REST-endpoint failure check whose own comment documents it as passing "with or without Lakekeeper reachable." It is a unit test and must keep running in the amber unit job — moving and tagging it would wrongly skip it there. ### Any related issues, documentation, discussions? Part of #6034 (Task 1 of 3). Does not close it — Tasks 2 (flip the `storage.conf` catalog default to `rest`) and 3 (mirror prod in the CI integration suite) follow, and Task 1 must land first. ### How was this PR tested? Test-file relocation with no production-code change, so verification is at the compile/placement level: - `sbt WorkflowCore/Test/compile` passes after the move — the four files leave `common/workflow-core`'s test scope cleanly; a grep confirms nothing else there references them. - The relocated specs depend only on `amber.core.*` / `common.config` / `org.apache.iceberg` / ScalaTest (all already on amber's test classpath), the moved `VirtualDocumentSpec`, and the existing `@IntegrationTest` tag — the same dependency set as the `IcebergRestCatalogIntegrationSpec` already compiling in this directory. The amber build in CI compiles the integration source set and confirms. - Behavior is unchanged; the three specs continue to run in the `amber-integration` job against a live catalog. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (claude-opus-4-8) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
