Ma77Ball opened a new issue, #6051:
URL: https://github.com/apache/texera/issues/6051

   ### Task Summary
   The MySQL source operator (`MySQLSourceOpDesc` / `MySQLSourceOpExec` / 
`MySQLConnUtil` under `common/workflow-operator/.../source/sql/mysql/`) was 
deprecated and made non-executable in #4386 when `mysql-connector-java` was 
dropped for being GPLv2 (ASF Category X). The classes are retained only so 
legacy saved workflows containing a `MySQLSource` node still deserialize 
(`LogicalOp.scala` still registers `name = "MySQLSource"`), which leaves the 
`MySQLSourceOpExec` execution path as unreachable dead code and records the 
retention rationale only in a `@deprecated` message and a test comment. 
Proposed cleanup: (1) remove the genuinely dead execution half 
(`MySQLSourceOpExec`, and `MySQLConnUtil` if unused elsewhere), keeping only 
the minimal non-executable `MySQLSourceOpDesc` stub required for 
deserialization; (2) add a one-line comment at the `LogicalOp.scala` 
registration site stating the type is retained non-executable for 
legacy-workflow deserialization (ref #4386), so the contrac
 t is discoverable at the point a maintainer would touch it. Full removal of 
the operator (a load-time migration/version-gate that rewrites legacy 
`MySQLSource` nodes, then deleting the desc and type registration) is deferred 
as a larger follow-up; it is not worth the migration risk for a single dormant 
operator right now.
   ### Task Type
   - [x] Refactor / cleanup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to