aglinxinyuan opened a new pull request, #6056:
URL: https://github.com/apache/texera/pull/6056

   ### What changes were proposed in this PR?
   
   Add unit test coverage for the two largest uncovered files in 
`workflow-core` per the Codecov report. No production-code changes.
   
   | File | Codecov before | Missed lines targeted |
   | --- | --- | --- |
   | `PhysicalPlan.scala` | 27.0% | 71 — `addOperator`/`addLink` (incl. schema 
hand-off + undeclared-port rejection), `removeLink`, `setOperator`, 
`getPhysicalOpByWorkerId`, `getLinksBetween`, `getOutputPartitionInfo` (all 
three branches), blocking/dependee link detection, 
`getDependeeLinksRemovedDAG`, `getNonBridgeNonBlockingLinks` (bridge vs 
diamond), `maxChains` (maximal-subset filter), 
`layeredReversedTopologicalOrder` (diamond, parallel edges, empty), plan-level 
`propagateSchema` |
   | `PhysicalOp.scala` | 46.2% | 66 — the Java-function 
`SchemaPropagationFunc` wrapper, all four factory families 
(`source`/`oneToOne`/`manyToOne`/`local`, both overloads each), 
`dependeeInputs`/`isInputLinkDependee`, `isPythonBased`/`getCode`, 
`withPartitionRequirement`/`withDerivePartition`/`withIsOneToManyOp`/`withPveName`,
 partial-schema propagation gating, `getInputPortDependencyPairs`, 
`addOutputLink` guards, primary-constructor defaults |
   
   New `PhysicalPlanSpec` and `PhysicalOpSpec` in `workflow-core` (no name 
clash repo-wide); deliberately does not duplicate the `PhysicalOp`/plan 
surfaces already covered by `WorkflowCoreTypesSpec`.
   
   ### Any related issues, documentation, discussions?
   
   Follow-up to the review feedback on #6043: prioritize tests that fill 
uncovered code paths.
   
   ### How was this PR tested?
   
   - `sbt "WorkflowCore/testOnly *PhysicalPlanSpec *PhysicalOpSpec"` — 38 
tests, all green
   - `sbt "WorkflowCore/Test/scalafmtCheck"` and `sbt "WorkflowCore/scalafixAll 
--check"` — clean
   - CI + Codecov delta to confirm
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to