aglinxinyuan opened a new pull request, #6084:
URL: https://github.com/apache/texera/pull/6084

   ### What changes were proposed in this PR?
   
   Add unit test coverage for three more `common/config` objects, selected from 
the Codecov report (all 0%). No production-code changes.
   
   | File | Codecov before | What the tests pin |
   | --- | --- | --- |
   | `KubernetesConfig.scala` | 0% | the fixed port, string/numeric/boolean 
settings, and comma-separated CPU/memory/GPU limit-option parsing (trimmed, 
non-empty) |
   | `UserSystemConfig.scala` | 0% | admin/google/smtp/project defaults, the 
version-collapse interval (name≠key), and the `appDomain` `None` path for a 
blank domain |
   | `AuthConfig.scala` | 0% | `jwtExpirationMinutes`, the configured 
lowercased secret + memoization, and `getRandomHexString` (32-char lowercase 
hex, fresh per call) via reflection |
   
   Reading each value forces resolution from the backing `.conf`; 
env-overridable values are guarded on the env var being unset (mirroring 
`StorageConfigSpec`). The random-secret branch is exercised directly rather 
than through the env-dependent `"random"` path.
   
   ### Any related issues, documentation, discussions?
   
   Follow-up to the review feedback on #6043: prioritize tests that fill 
uncovered code paths.
   
   ### How was this PR tested?
   
   - `sbt "Config/testOnly *KubernetesConfigSpec *UserSystemConfigSpec 
*AuthConfigSpec"` — 10 tests, all green
   - `sbt "Config/Test/scalafmtCheck"` and `sbt "Config/scalafixAll --check"` — 
clean
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8 [1M context])
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to