Yicong-Huang opened a new pull request, #6092:
URL: https://github.com/apache/texera/pull/6092
### What changes were proposed in this PR?
Add `all_launchers_present` in `bin/local-dev/main.sh`: a helper that
returns 0 iff every non-skipped JVM service's `SVC_LAUNCHER` file exists on
disk. Gate `build_all()`'s auto short-circuit on this predicate — instead of `!
any_jvm_src_changed`, it's now `! any_jvm_src_changed &&
all_launchers_present`. When any expected launcher is missing, the
short-circuit is bypassed so the normal build + unzip pipeline runs and
restores the unpacked dist dirs. `SVC_LAUNCHER` already embeds
`${TEXERA_VERSION}` (`target/<svc>-${TEXERA_VERSION}/bin/<svc>`), so the
presence check also catches version bumps — an old launcher path won't satisfy
the new one.
### Any related issues, documentation, discussions?
Closes #6091.
### How was this PR tested?
Added a static regression test in `bin/local-dev/tests/test_local_dev_sh.sh`
covering the helper's definition and the short-circuit's use of it (35/35
pass), and reproduced the pre-fix failure locally by `sbt clean dist`-then-`up`
— before this change `up` reported `sbt dist: skipped (no source changes since
last build)` followed by `launcher missing`, after this change it re-runs the
build + unzip and every JVM launches.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (1M context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
