mengw15 commented on PR #6083: URL: https://github.com/apache/texera/pull/6083#issuecomment-4881028100
One forward-looking note on `EnvironmentalVariableSpec`: the `allNames` list is a hand-maintained mirror of the object, so a newly added `ENV_*` constant silently falls outside every assertion and the uniqueness check erodes over time. Enumerating the constants reflectively (all no-arg `String` members named `ENV_*`) would make the spec self-updating. While there, `name.trim should not be empty` only rejects all-whitespace names — a padded name like `"STORAGE_JDBC_URL "` still passes, which is the sneakier failure (env lookups silently miss); asserting `name shouldBe name.trim` or a `^[A-Z][A-Z0-9_]*$` shape check would cover both. Fine as a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
