Yicong-Huang opened a new pull request, #6097:
URL: https://github.com/apache/texera/pull/6097

   ### What changes were proposed in this PR?
   
   `build_all` in `bin/local-dev/main.sh` passed three CLI-only sbt knobs that 
each made `sbt <svc>/dist` produce a dist that packaged and reported success 
but could not run. This PR removes all three and keeps only the heap/GC flags.
   
   - `-Dsbt.pipelining=true`: inter-project dependencies are consumed as 
early-output signature jars, so the dist drops the real 
`dao`/`auth`/`config`/`resource` jars from `lib/` and every service dies at 
startup with `NoClassDefFoundError` on a sibling-module class (e.g. 
`org/apache/texera/dao/SqlServer$`).
   - `set every (Compile / doc / sources) := Seq.empty`: `set every` ignores 
the written scope and zeroes the shared `sources` key in every scope, including 
`Compile / sources`, so nothing compiles, no main class is discovered, and no 
`bin/<service>` launcher is generated.
   - `set every (Compile / packageDoc / publishArtifact) := false`: the same 
`set every` trap turns off `publishArtifact` for the main jar artifacts too, so 
the inter-project dependency jars drop out of the dist.
   
   The regression tests in `test_local_dev_sh.sh` are flipped to guards that 
fail if any of these knobs is reintroduced. Skipping scaladoc has to be done 
per-project in `build.sbt`, not with a global `set every`, so it is left out 
until it can be done safely.
   
   ### Any related issues, documentation, discussions?
   
   Closes #6096
   
   ### How was this PR tested?
   
   Verified a clean multi-project dist bundles the 
`dao`/`auth`/`config`/`resource` jars and a working `bin/<service>` launcher, 
and that `bin/local-dev/tests/test_local_dev_sh.sh` passes.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Claude Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to