Copilot commented on code in PR #6098: URL: https://github.com/apache/texera/pull/6098#discussion_r3522882104
########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/sleep/SleepOpExecSpec.scala: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.sleep + +import org.apache.texera.amber.core.tuple.{Attribute, AttributeType, Schema, Tuple} +import org.apache.texera.amber.util.JSONUtils.objectMapper +import org.scalatest.flatspec.AnyFlatSpec + +class SleepOpExecSpec extends AnyFlatSpec { + + private val schema: Schema = Schema().add(new Attribute("v", AttributeType.INTEGER)) + + private def tuple(v: Int): Tuple = + Tuple.builder(schema).add(new Attribute("v", AttributeType.INTEGER), Integer.valueOf(v)).build() + + // SleepOpDesc is a LogicalOp: serialize a real instance so the polymorphic operatorType + // discriminator is present (a hand-written JSON string would fail to deserialize). + private def descString(sleepTime: Int): String = { + val desc = new SleepOpDesc() + desc.sleepTime = sleepTime + objectMapper.writeValueAsString(desc) + } + + "SleepOpExec" should "construct from a serialized SleepOpDesc" in { + val exec = new SleepOpExec(descString(0)) + assert(exec != null) + } + + "SleepOpExec.processTuple" should "return the input tuple unchanged" in { + // sleepTime = 0 -> Thread.sleep(0), instant + val exec = new SleepOpExec(descString(0)) + val emitted = exec.processTuple(tuple(7), 0).toList + assert(emitted.map(_.asInstanceOf[Tuple]) == List(tuple(7))) + } Review Comment: The `.asInstanceOf[Tuple]` cast is unnecessary here (SleepOpExec returns the same input `Tuple`), and it makes the test less clear. Comparing the emitted list directly avoids an unsafe cast. ########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/sleep/SleepOpExecSpec.scala: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.amber.operator.sleep + +import org.apache.texera.amber.core.tuple.{Attribute, AttributeType, Schema, Tuple} +import org.apache.texera.amber.util.JSONUtils.objectMapper +import org.scalatest.flatspec.AnyFlatSpec + +class SleepOpExecSpec extends AnyFlatSpec { + + private val schema: Schema = Schema().add(new Attribute("v", AttributeType.INTEGER)) + + private def tuple(v: Int): Tuple = + Tuple.builder(schema).add(new Attribute("v", AttributeType.INTEGER), Integer.valueOf(v)).build() + + // SleepOpDesc is a LogicalOp: serialize a real instance so the polymorphic operatorType + // discriminator is present (a hand-written JSON string would fail to deserialize). + private def descString(sleepTime: Int): String = { + val desc = new SleepOpDesc() + desc.sleepTime = sleepTime + objectMapper.writeValueAsString(desc) + } + + "SleepOpExec" should "construct from a serialized SleepOpDesc" in { + val exec = new SleepOpExec(descString(0)) + assert(exec != null) + } + + "SleepOpExec.processTuple" should "return the input tuple unchanged" in { + // sleepTime = 0 -> Thread.sleep(0), instant + val exec = new SleepOpExec(descString(0)) + val emitted = exec.processTuple(tuple(7), 0).toList + assert(emitted.map(_.asInstanceOf[Tuple]) == List(tuple(7))) + } + + it should "emit exactly one tuple per input" in { + val exec = new SleepOpExec(descString(0)) + val emitted = (0 until 5).flatMap(i => exec.processTuple(tuple(i), 0).toList) + assert(emitted.map(_.asInstanceOf[Tuple]) == (0 until 5).map(tuple).toList) Review Comment: Same as above: avoid `.asInstanceOf[Tuple]` and compare emitted tuples directly to keep the test type-safe and easier to read. ########## common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/intervalJoin/IntervalOpExecSpec.scala: ########## @@ -498,4 +498,38 @@ class IntervalOpExecSpec extends AnyFlatSpec with BeforeAndAfter { ) } + it should "join timestamps across every interval unit" in { + val base = Timestamp.valueOf("2020-01-01 00:00:00") + Seq( + TimeIntervalType.YEAR, + TimeIntervalType.MONTH, + TimeIntervalType.HOUR, + TimeIntervalType.MINUTE, + TimeIntervalType.SECOND + ).foreach { unit => + val desc = new IntervalJoinOpDesc("point", "range", 3L, true, true, unit) + val exec = new IntervalJoinOpExec(objectMapper.writeValueAsString(desc)) + exec.open() + assert(exec.processTuple(timeStampTuple("range", 1, base), right).isEmpty) + val out = exec.processTuple(timeStampTuple("point", 1, base), left).toList + assert(out.size == 1, s"expected a match for unit $unit") + assert(out.head.getFields.length == 4) + exec.close() Review Comment: `exec.close()` is not guaranteed to run if an assertion fails inside the loop, which can leak resources and make later tests flaky. Wrapping the body in `try`/`finally` ensures the executor is always closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
