Yicong-Huang opened a new pull request, #6124: URL: https://github.com/apache/texera/pull/6124
### What changes were proposed in this PR? Renames the Amber master actor from **Controller** to **Coordinator** across the whole engine — classes, variables, comments, protobuf, and tests: | Area | Change | | --- | --- | | Scala package | `architecture.controller` → `architecture.coordinator` (dirs moved with `git mv`) | | Scala classes | `Controller` → `Coordinator`, `ControllerProcessor` → `CoordinatorProcessor`, `ControllerConfig` → `CoordinatorConfig`, `ControllerAsyncRPCHandlerInitializer`, `ControllerTimerService`, `ControllerSpec` → `Coordinator*` | | gRPC proto | `controllerservice.proto` → `coordinatorservice.proto`; `service ControllerService` → `CoordinatorService`; rpc `ControllerInitiateQueryStatistics` → `CoordinatorInitiateQueryStatistics`; scalapb `extends` option and proto comments | | Python runtime | `controller_interface` / `_controller_service_stub` / `controller_stub` → `coordinator_*`; generated betterproto bindings are gitignored and regenerate from the renamed proto (`bin/python-proto-gen.sh` verified) | | Actor identity | `CONTROLLER` ActorVirtualIdentity constant → `COORDINATOR` (Scala + Python) | | Location preference | `PreferController` → `PreferCoordinator` (workflow-core) | | Variables / comments | all camelCase & snake_case variants (`controllerConfig`, `controllerTimerService`, `controllerAddress`, …) and prose in scaladoc/docstrings | The rename is purely mechanical (case-preserving substring replacement, verified exhaustively): `grep -ri controller` over `amber/` and `common/` returns zero matches afterwards. Untouched on purpose: Angular's `HttpTestingController`, the Web `AbortController` in agent-service, and Envoy's `gatewayclass-controller` in the k8s templates. Built on top of #6123, which freed the Coordinator name by renaming the region-scheduling coordinators to managers. ### Any related issues, documentation, discussions? Closes #6122. Depends on #6123 (this branch is stacked on it; the first commit belongs to that PR). ### How was this PR tested? Refactor with no behavior change — existing tests stay green with no assertion edits: ``` sbt "WorkflowCore/testOnly org.apache.texera.amber.core.workflow.WorkflowCoreTypesSpec org.apache.texera.amber.core.workflow.PhysicalOpSpec org.apache.texera.amber.util.VirtualIdentityUtilsSpec" sbt "WorkflowOperator/testOnly org.apache.texera.amber.operator.SpecialPhysicalOpFactorySpec" sbt "WorkflowExecutionService/testOnly org.apache.texera.amber.engine.architecture.coordinator.CoordinatorSpec org.apache.texera.amber.engine.architecture.coordinator.ClientEventSpec org.apache.texera.amber.engine.architecture.coordinator.WorkflowSchedulerSpec org.apache.texera.amber.engine.architecture.scheduling.WorkflowExecutionManagerSpec org.apache.texera.amber.engine.architecture.scheduling.RegionExecutionManagerSpec" cd amber && python -m pytest src/test/python/core/architecture/rpc/test_async_rpc_client.py src/test/python/core/util/test_virtual_identity.py src/test/python/core/runnables/test_console_message.py src/test/python/core/runnables/test_data_processor.py src/test/python/core/runnables/test_main_loop.py src/test/python/pytexera/storage/test_large_binary_manager.py ``` Full `Test/compile` of `WorkflowCore`, `WorkflowOperator`, and `WorkflowExecutionService` passes; Python bindings regenerated via `bin/python-proto-gen.sh` and 68 pytest cases pass. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Fable 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
