aglinxinyuan opened a new pull request, #6126: URL: https://github.com/apache/texera/pull/6126
### What changes were proposed in this PR? Remove the dead `CacheSourceOpExec` executor and its `OpExecSource` plumbing. Cache source operators were replaced by input-port materialization reader threads in #3425 (the symmetric follow-up to sink-operator removal in #3312). The scheduler no longer inserts a cache-source read op for a materialized link — it tags the downstream input port with the URI directly: ``` Before (pre-#3425): upstream OutputPort(URI) ──► [CacheSourceOpExec] ──► downstream InputPort After (#3425+): upstream OutputPort(URI) ─────────────────────────► downstream InputPort(URI) ``` Since then `CacheSourceOpExec` has been unreachable: `SpecialPhysicalOpFactory.newSourcePhysicalOp` — the only producer of an `OpExecSource` init-info, which is what constructed `CacheSourceOpExec` in `DataProcessorRPCHandlerInitializer.setupExecutor` — has no production caller (its only references were its own spec). Removed: | Item | Location | | --- | --- | | `CacheSourceOpExec` | `common/workflow-operator/.../source/cache/CacheSourceOpExec.scala` | | `SpecialPhysicalOpFactory` (+ spec) | `common/workflow-operator/.../operator/SpecialPhysicalOpFactory.scala` | | `OpExecSource` match arm + now-unused `CacheSourceOpExec`/`URI` imports | `amber/.../worker/DataProcessorRPCHandlerInitializer.scala` | | `OpExecSource` message + `opExecSource = 3` oneof field | `common/workflow-core/.../protobuf/.../executor.proto` | The `OpExecInitInfo` oneof is an internal controller↔worker wire format (built and consumed within the same deployment; `preserve_unknown_fields: false`), so dropping the field is safe. Field number `3` is now `reserved` to prevent reuse, and the newly-unused `virtualidentity.proto` import is dropped. ### Any related issues, documentation, discussions? Closes #6125. The dead code was discovered during review of the test-coverage PR #6098 (the `CacheSourceOpExecSpec` added there was dropped rather than kept). ### How was this PR tested? No behavioral change — pure dead-code removal. - `sbt "WorkflowOperator/compile" "WorkflowExecutionService/compile"` — green (proto regenerates; the `OpExecInitInfo` match remains exhaustive without the `OpExecSource` case) - `sbt "WorkflowExecutionService/scalafmtCheck" "WorkflowExecutionService/scalafixAll --check"` — clean ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8 [1M context]) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
