mengw15 commented on code in PR #6049:
URL: https://github.com/apache/texera/pull/6049#discussion_r3524513954


##########
.github/workflows/build.yml:
##########
@@ -281,6 +281,8 @@ jobs:
         # those run in the amber-integration job below.
         env:
           AMBER_TEST_FILTER: skip-integration
+          # unit job uses its provisioned postgres catalog; default (rest) 
needs a Lakekeeper not run here
+          STORAGE_ICEBERG_CATALOG_TYPE: postgres

Review Comment:
   Sounds good — thanks! Tracking the unit/e2e test-taxonomy cleanup in #6047.



##########
common/config/src/main/resources/storage.conf:
##########
@@ -21,7 +21,7 @@ storage {
     # Configuration for Apache Iceberg, used for storing the workflow results 
& stats
     iceberg {
         catalog {
-            type = postgres # either hadoop, rest, or postgres
+            type = rest # either hadoop, rest, or postgres

Review Comment:
   Makes sense as a cleanup. Since it officially drops a supported catalog 
type, I'll open a separate issue to track the removal, where we can gather 
input before dropping it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to