Copilot commented on code in PR #6175:
URL: https://github.com/apache/texera/pull/6175#discussion_r3525942807
##########
agent-service/package.json:
##########
@@ -15,7 +15,7 @@
"format:check": "prettier --check \"src/**/*.{ts,tsx,json}\""
},
"dependencies": {
- "@ai-sdk/openai": "3.0.73",
+ "@ai-sdk/openai": "4.0.7",
"@elysiajs/cors": "1.4.0",
"ai": "6.0.208",
"ajv": "8.18.0",
Review Comment:
This update bumps `@ai-sdk/openai` across a major version, but the service
still pins `ai` to 6.0.208. In the generated lockfile, `[email protected]` depends on
`@ai-sdk/[email protected]` / `@ai-sdk/[email protected]`, while
`@ai-sdk/[email protected]` pulls in `@ai-sdk/[email protected]` /
`@ai-sdk/[email protected]` (plus `@workflow/serde`). Since the code passes
`openai.chat(modelType)` into `generateText` (see `src/server.ts` +
`src/agent/texera-agent.ts`), this cross-major mismatch is very likely to cause
type incompatibilities or runtime behavior changes. Please align the `ai` and
`@ai-sdk/*` package major versions (upgrade as a set) or keep `@ai-sdk/openai`
on the compatible 3.x line, and rerun `bun test` + `bun run typecheck` after
the alignment.
##########
agent-service/package.json:
##########
@@ -15,7 +15,7 @@
"format:check": "prettier --check \"src/**/*.{ts,tsx,json}\""
},
"dependencies": {
- "@ai-sdk/openai": "3.0.73",
+ "@ai-sdk/openai": "4.0.7",
"@elysiajs/cors": "1.4.0",
Review Comment:
`agent-service/LICENSE-binary` still lists `@ai-sdk/[email protected]` (and the
related @ai-sdk/* versions). Since CI generates a production dependency
manifest and checks it against this per-module LICENSE-binary (see
`.github/workflows/build.yml`), this dependency bump will likely fail the
license drift check unless the LICENSE-binary entries are updated to match the
new bundled versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
