aglinxinyuan commented on PR #6188:
URL: https://github.com/apache/texera/pull/6188#issuecomment-4888230578
Pushed two commits to get CI green here:
1. **`check_binary_deps` drift** — `frontend/LICENSE-binary` still pinned
the pre-bump versions of four *bundled* direct deps, and direct-dep drift
always blocks. Synced them: `ng-zorro-antd` 21.3.1→21.3.2, `rxjs` 7.8.1→7.8.2,
`uuid` 14.0.0→14.0.1, `y-monaco` 0.1.5→0.1.6. (`@lezer/python` and
`y-protocols` are transitive / already in sync, so they weren't flagged.)
2. **`test:ci` compile error (`TS2345`)** — rxjs 7.8.2 tightened
`Subscriber.next()` to reject `undefined`, which surfaced a latent unsafe
optional-chained `.find()?.` in `StubWorkflowPersistService`. It only breaks
the *test* build (the stub isn't in the prod bundle), which is why `build:ci`
stayed green while `test:ci` failed. Cast the emitted value to `Workflow` to
match the `Observable<Workflow>` contract — no runtime-behavior change.
Ran the full suite locally against the bumped deps (node v24.15.0, rxjs
7.8.2) — clean, no `TS2345`:
```
Test Files 125 passed | 1 skipped (126)
Tests 1333 passed | 2 skipped | 1 todo (1336)
NX Successfully ran target test for project gui
```
All the specs that consume the stub pass — `download` (15),
`workflow-version` (30), `filters` (4), `workspace` (24), `hub-workflow-detail`
(32), `user-workflow` (12).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
