aglinxinyuan commented on PR #6173: URL: https://github.com/apache/texera/pull/6173#issuecomment-4888283825
Verified locally — `[email protected]` is API-compatible with `pyright-language-service`, safe to merge. The service only touches these exports in `src/server-commons.ts`, and all of them carry over unchanged in 3.5.0 (checked against the published type definitions): | Symbol | Imported from | |---|---| | `IWebSocket`, `WebSocketMessageReader(socket)`, `WebSocketMessageWriter(socket)` | `vscode-ws-jsonrpc` | | `createConnection(reader, writer, onDispose)`, `createServerProcess(name, cmd, args, opts)`, `forward(client, server, map)` | `vscode-ws-jsonrpc/server` | The exports map (`.` / `./server` / `./socket`) and the transitive `vscode-jsonrpc "~8.2.1"` pin are both unchanged from 3.3.2 — the only 3.5.0 change (TypeFox/monaco-languageclient#949) is an internal refactor to consume `vscode-jsonrpc`'s public exports instead of deep import paths. `tsc --noEmit` on the source passes clean against the bumped version. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
