aglinxinyuan commented on PR #6172:
URL: https://github.com/apache/texera/pull/6172#issuecomment-4888288267
Heads up — this bump doesn't actually compile. I pulled the branch and ran
the `pyright-language-service` typecheck locally:
```
src/server-commons.ts(13,60): error TS2307: Cannot find module
'vscode-languageserver' or its corresponding type declarations.
There are types at '.../vscode-languageserver/lib/common/api.d.ts', but
this result could not be
resolved under your current 'moduleResolution' setting. Consider updating
to 'node16', 'nodenext', or 'bundler'.
src/server-commons.ts(48,21): error TS2339: Property 'method' does not exist
on type 'Message'.
src/server-commons.ts(49,44): error TS2339: Property 'params' does not exist
on type 'Message'.
```
vscode-languageserver 10 moved to `exports`-based entry points, which the
package's legacy `"moduleResolution": "node"` in `tsconfig.json` can't follow —
the two `Message` errors cascade from that failed resolution.
| Check | as-is | with `moduleResolution: "bundler"` |
|---|---|---|
| `yarn install --frozen-lockfile` | ✅ (lockfile consistent) | ✅ |
| `tsc --noEmit` | ❌ 3 errors | ✅ clean |
| Node ESM load of `vscode-languageserver@10` | ✅ (resolves at runtime) | ✅ |
The reason every check here is green is that `pyright-language-service/` has
**no CI coverage at all** — it isn't in the frontend yarn workspace and no
build job touches it, so a Dependabot PR here only picks up the no-op
`dependencies` label and every stack skips. This bump would have merged
red-but-looking-green.
Fix is ready and verified locally: flip the tsconfig `moduleResolution` to
`bundler` (keeps `module: ESNext` + the `.ts`-extension imports; runtime is
unaffected since ts-node/Node resolve `exports` natively), plus a small `build
/ pyright-language-service` job — `yarn install --frozen-lockfile` → `tsc
--noEmit` — and a labeler mapping so this class of breakage can't skip CI
again. Will push it to this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
